Skip to content

Updated the AppService Swagger to include ElasticPremium and ElasticIsolated Skus, and a new MaximumElasticWorkerCount parameter.#4006

Merged
hovsepm merged 1 commit intoAzure:masterfrom
jocawtho:master
Sep 26, 2018
Merged

Updated the AppService Swagger to include ElasticPremium and ElasticIsolated Skus, and a new MaximumElasticWorkerCount parameter.#4006
hovsepm merged 1 commit intoAzure:masterfrom
jocawtho:master

Conversation

@jocawtho
Copy link
Copy Markdown
Member

@jocawtho jocawtho commented Sep 25, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI AutorestCI mentioned this pull request Sep 25, 2018
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 25, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3312

@AutorestCI AutorestCI mentioned this pull request Sep 25, 2018
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 25, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1611

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 25, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Encountered a Subprocess error: (azure-sdk-for-js)

Command: ['/usr/local/bin/autorest', '/tmp/tmprwylhcpq/rest/specification/web/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmprwylhcpq/azure-sdk-for-js', '--typescript', '--use=@microsoft.azure/autorest.typescript@2.0.516']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4286/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4286)
   Loading AutoRest extension '@microsoft.azure/autorest.typescript' (2.0.516->2.0.516)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Sep 25, 2018

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from hovsepm September 25, 2018 23:46
@AutorestCI AutorestCI mentioned this pull request Sep 25, 2018
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 25, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2828

@AutorestCI AutorestCI mentioned this pull request Sep 26, 2018
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 26, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2218

@AutorestCI AutorestCI mentioned this pull request Sep 26, 2018
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 26, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3702

@hovsepm hovsepm merged commit 96993c3 into Azure:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hovsepm hovsepm hovsepm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hovsepm hovsepm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jocawtho @AutorestCI @azuresdkci @hovsepm